[
https://issues.apache.org/jira/browse/FLINK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321906#comment-16321906
]
ASF GitHub Bot commented on FLINK-7938:
---------------------------------------
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5281
[FLINK-7938] support addAll() in ListState
## What is the purpose of the change
support `addAll()` in `ListState`, so Flink can be more efficient in adding
elements to `ListState` in batch. This should give us a much better performance
especially for `ListState` backed by RocksDB
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a
persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(100MB)*
- *Extended integration test for recovery after master (JobManager)
failure*
- *Added test that validates that TaskInfo is transferred only once
across recoveries*
- *Manually verified the change by running a 4 node cluser with 2
JobManagers and 4 TaskManagers, a stateful streaming program, and killing one
JobManager and two TaskManagers during the execution, verifying that recovery
happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no /
don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-7938
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5281.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5281
----
commit 74e4e3cd7f81621963640774e174bc8814c609e6
Author: Bowen Li <bowenli86@...>
Date: 2018-01-02T19:21:28Z
update local branch
commit 362bad9a7259a7b75e034c81d488fd09ca506df3
Author: Bowen Li <bowenli86@...>
Date: 2018-01-04T01:35:11Z
remove sh
commit 24b5a38c73e812340b891f91706e75ca6a183673
Author: Bowen Li <bowenli86@...>
Date: 2018-01-11T09:11:55Z
add ListState#addAll()
----
> support addAll() in ListState
> -----------------------------
>
> Key: FLINK-7938
> URL: https://issues.apache.org/jira/browse/FLINK-7938
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Reporter: Bowen Li
> Assignee: Bowen Li
> Fix For: 1.5.0
>
>
> support {{addAll()}} in {{ListState}}, so Flink can be more efficient in
> adding elements to {{ListState}} in batch. This should give us a much better
> performance especially for {{ListState}} backed by RocksDB
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
