[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5184#discussion_r160692288
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java 
---
    @@ -357,6 +360,31 @@ public void start() throws Exception {
                return 
CompletableFuture.completedFuture(jobManagerServices.blobServer.getPort());
        }
     
    +   @Override
    +   public CompletableFuture<JobExecutionResult> getJobExecutionResult(
    +                   final JobID jobId,
    +                   final Time timeout) {
    +
    +           final JobExecutionResult jobExecutionResult = 
jobExecutionResultCache.get(jobId);
    +           if (jobExecutionResult == null) {
    +                   return FutureUtils.completedExceptionally(new 
JobExecutionResultNotFoundException(jobId));
    +           } else {
    +                   return 
CompletableFuture.completedFuture(jobExecutionResult);
    +           }
    +   }
    +
    +   @Override
    +   public CompletableFuture<Boolean> isJobExecutionResultPresent(
    --- End diff --
    
    True. Keep it like this.


---