[ 
https://issues.apache.org/jira/browse/FLINK-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319977#comment-16319977
 ] 

ASF GitHub Bot commented on FLINK-6892:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4127#discussion_r160629614
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
 ---
    @@ -352,6 +352,24 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
           "Flink~~~~xx")
       }
     
    +  @Test
    +  def testLpad(): Unit = {
    +    testSqlApi("LPAD('hi',4,'??')", "??hi")
    +    testSqlApi("LPAD('hi',1,'??')", "h")
    +    testSqlApi("LPAD('',1,'??')", "?")
    +    testSqlApi("LPAD('',30,'??')", "??????????????????????????????")
    +    testSqlApi("LPAD('111',-2,'??')", "")
    --- End diff --
    
    Is `testSqlApi("LPAD('111',-2,'??')", "")` standard?
    I just tested this with MySQL and it returns NULL


> Add L/RPAD supported in SQL
> ---------------------------
>
>                 Key: FLINK-6892
>                 URL: https://issues.apache.org/jira/browse/FLINK-6892
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> L/RPAD(str,len,padstr) Returns the string str, left/right-padded with the 
> string padstr to a length of len characters. If str is longer than len, the 
> return value is shortened to len characters.
> * Syntax:
> LPAD(str,len,padstr) 
> * Arguments
> **str: -
> **len: -
> **padstr: -
> * Return Types
>   String
> * Example:
>   LPAD('hi',4,'??') -> '??hi'
>   LPAD('hi',1,'??') -> 'h'
>   RPAD('hi',4,'??') -> 'hi??'
>   RPAD('hi',1,'??') -> 'h'
> * See more:
> ** [MySQL| 
> https://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_lpad]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to