[
https://issues.apache.org/jira/browse/FLINK-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318754#comment-16318754
]
ASF GitHub Bot commented on FLINK-8392:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5266
[FLINK-8392] [rpc] Let termination future be completed by
AkkaRpcActor#postStop
## What is the purpose of the change
Revert the changes introduced by FLINK-7754. An RpcEndpoint's termination
future is now
completed from the AkkaRpcActor#postStop method. This enables that we can
wait in the `RpcEndpoint#postStop` method on the termination of logically
nested `RpcEndpoint`.
## Verifying this change
- Covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink
simplifyRpcTerminationFuture
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5266
----
commit f9bccf20b046e4f73a52ca2a4b842ca985dfaaa8
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-09T16:50:37Z
[FLINK-8392] [rpc] Let termination future be completed by
AkkaRpcActor#postStop
Revert the changes introduced by FLINK-7754. An RpcEndpoint's termination
future is now
completed from the AkkaRpcActor#postStop method.
----
> Simplify termination future completion
> --------------------------------------
>
> Key: FLINK-8392
> URL: https://issues.apache.org/jira/browse/FLINK-8392
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> With FLINK-7754, we tried to complete the termination future after an
> {{Actor}} has been completely stopped and has been removed from the
> {{ActorSystem}}. This, however, is not possible. Furthermore, this change
> made it impossible that a {{RpcEndpoint}} waits for the termination of
> another {{RpcEndpoint}} in its {{RpcEndpoint#postStop}} method. Therefore, I
> propose to revert the changes done by FLINK-7754.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
