[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318457#comment-16318457 ]
ASF GitHub Bot commented on FLINK-8325: --------------------------------------- Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160413930 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -145,6 +145,14 @@ class DataStreamOverAggregate( inputSchema.typeInfo, Some(constants)) + val constantsTypeInfo = + Some(constants).map(_.map(generator.generateExpression(_))).getOrElse(Seq()).map(_.resultType) + val aggInputTypeInfo = constantsTypeInfo.++:(inputSchema.fieldTypeInfos) + + val aggregateInputType = + cluster.getTypeFactory.asInstanceOf[FlinkTypeFactory] --- End diff -- +1 > Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1) > ------------------------------------------------------------------ > > Key: FLINK-8325 > URL: https://issues.apache.org/jira/browse/FLINK-8325 > Project: Flink > Issue Type: Bug > Components: Table API & SQL > Affects Versions: 1.5.0 > Reporter: sunjincheng > Assignee: sunjincheng > > COUNT(1) with Group Window, always output 0. > e.g. > DATA: > {code} > val data = List( > (1L, 1, "Hi"), > (2L, 2, "Hello"), > (4L, 2, "Hello"), > (8L, 3, "Hello world"), > (16L, 3, "Hello world")) > {code} > SQL: > {code} > SELECT b, COUNT(1) FROM MyTable GROUP BY Hop(proctime, interval '0.001' > SECOND, interval '0.002' SECOND),b > {code} > OUTPUT: > {code} > 1,0,1, > 1,0,1, > 2,0,1, > 2,0,1, > 2,0,2, > 3,0,1, > 3,0,1 > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)