[ 
https://issues.apache.org/jira/browse/FLINK-7797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314404#comment-16314404
 ] 

ASF GitHub Bot commented on FLINK-7797:
---------------------------------------

Github user xccui commented on the issue:

    https://github.com/apache/flink/pull/5140
  
    Hi @fhueske, thanks for your concrete suggestions! IMO, the refactorings in 
`TimeBoundedStreamJoin` are quite reasonable, while the refactoring for 
`createNegativeWindowSizeJoin()` may not be so significant as the negative 
window size should be taken as an exception. Anyway, I've applied them for 
better efficiency. 😄
    
    Thanks, Xingcan


> Add support for windowed outer joins for streaming tables
> ---------------------------------------------------------
>
>                 Key: FLINK-7797
>                 URL: https://issues.apache.org/jira/browse/FLINK-7797
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Xingcan Cui
>
> Currently, only windowed inner joins for streaming tables are supported.
> This issue is about adding support for windowed LEFT, RIGHT, and FULL OUTER 
> joins.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to