Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5140#discussion_r159009795
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala
---
@@ -62,15 +65,23 @@ abstract class TimeBoundedStreamInnerJoin(
with Compiler[FlatJoinFunction[Row, Row, Row]]
with Logging {
- private var cRowWrapper: CRowWrappingCollector = _
+ private val leftArity = leftType.getArity
+ private val rightArity = rightType.getArity
+ private val resultArity = leftArity + rightArity
+
+ // two reusable padding results
+ private val leftNullPaddingResult = new Row(resultArity)
--- End diff --
I think we can move the code to generate padded results into a util class
that can be reused by other joins.
---
