[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5184#discussion_r157878862
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java
 ---
    @@ -358,12 +360,12 @@ private DetachedFinalizer(JobID jobID, int 
numJobManagersToWaitFor) {
                }
     
                @Override
    -           public void jobFinished(JobExecutionResult result) {
    +           public void 
jobFinished(org.apache.flink.runtime.jobmaster.JobExecutionResult result) {
                        decrementCheckAndCleanup();
                }
     
                @Override
    -           public void jobFailed(Throwable cause) {
    +           public void 
jobFailed(org.apache.flink.runtime.jobmaster.JobExecutionResult result) {
    --- End diff --
    
    Maybe rename to `JobResult` after all to avoid fqn.


---