[
https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291328#comment-16291328
]
ASF GitHub Bot commented on FLINK-8234:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157026590
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobExecutionResultHandler.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.handler.job;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.runtime.messages.FlinkJobNotFoundException;
+import
org.apache.flink.runtime.messages.JobExecutionResultNotFoundException;
+import org.apache.flink.runtime.rest.handler.AbstractRestHandler;
+import org.apache.flink.runtime.rest.handler.HandlerRequest;
+import org.apache.flink.runtime.rest.handler.RestHandlerException;
+import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
+import org.apache.flink.runtime.rest.messages.JobIDPathParameter;
+import org.apache.flink.runtime.rest.messages.JobMessageParameters;
+import org.apache.flink.runtime.rest.messages.job.JobExecutionResult;
+import
org.apache.flink.runtime.rest.messages.job.JobExecutionResultHeaders;
+import
org.apache.flink.runtime.rest.messages.job.JobExecutionResultResponseBody;
+import org.apache.flink.runtime.webmonitor.RestfulGateway;
+import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever;
+import org.apache.flink.util.ExceptionUtils;
+
+import
org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus;
+
+import javax.annotation.Nonnull;
+
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionException;
+
+/**
+ * Returns the {@link org.apache.flink.api.common.JobExecutionResult} for
a given {@link JobID}.
+ */
+public class JobExecutionResultHandler
--- End diff --
Sample response after running batch WordCount example:
```
{
"status": {
"id": "CREATED"
},
"job-execution-result": {
"id": "533a165a6de7f70919a54b1d6f36d3b3",
"net-runtime": 0,
"accumulator-results": {
"94a58184eb17398571f35da42b714517":
"rO0ABXNyABNqYXZhLnV0aWwuQXJyYXlMaXN0eIHSHZnHYZ0DAAFJAARzaXpleHAAAACqdwQAAACqdXIAAltCrPMX+AYIVOACAAB4cAAAAAYCYQAAAAV1cQB+AAIAAAALB2FjdGlvbgAAAAF1cQB+AAIAAAAKBmFmdGVyAAAAAXVxAH4AAgAAAAwIYWdhaW5zdAAAAAF1cQB+AAIAAAAIBGFsbAAAAAJ1cQB+AAIAAAAIBGFuZAAAAAx1cQB+AAIAAAAJBWFybXMAAAABdXEAfgACAAAACwdhcnJvd3MAAAABdXEAfgACAAAACQVhd3J5AAAAAXVxAH4AAgAAAAcDYXkAAAABdXEAfgACAAAACQViYXJlAAAAAXVxAH4AAgAAAAcDYmUAAAAEdXEAfgACAAAACQViZWFyAAAAA3VxAH4AAgAAAAsHYm9ka2luAAAAAXVxAH4AAgAAAAoGYm91cm4AAAABdXEAfgACAAAACARidXQAAAABdXEAfgACAAAABwNieQAAAAJ1cQB+AAIAAAANCWNhbGFtaXR5AAAAAXVxAH4AAgAAAAkFY2FzdAAAAAF1cQB+AAIAAAAJBWNvaWwAAAABdXEAfgACAAAACQVjb21lAAAAAXVxAH4AAgAAAA8LY29uc2NpZW5jZQAAAAF1cQB+AAIAAAARDWNvbnN1bW1hdGlvbgAAAAF1cQB+AAIAAAAOCmNvbnR1bWVseQAAAAF1cQB+AAIAAAAMCGNvdW50cnkAAAABdXEAfgACAAAADAhjb3dhcmRzAAAAAXVxAH4AAgAAAA0JY3VycmVudHMAAAABdXEAfgACAAAABgJkAAAABHVxAH4AAgAAAAoGZGVhdGgAAAACdXEAfgACAAAACgZkZWxheQAAAAF1cQB+AAIAAAALB2Rlc3BpcwAAAAF1cQB+AAIAAAANCWRldm91dGx5AAAAAXVxAH4AAgAAAAgEZGllAAAAAnVxAH4AAgAAAAkFZG9lcwAAAAF1cQB+AAIAAAAKBmRyZWFkAAAAAXVxAH4AAgAAAAoGZHJlYW0AAAABdXEAfgACAAAACwdkcmVhbXMAAAABdXEAfgACAAAACARlbmQAAAACdXEAfgACAAAAEAxlbnRlcnByaXNlcwAAAAF1cQB+AAIAAAAHA2VyAAAAAXVxAH4AAgAAAAkFZmFpcgAAAAF1cQB+AAIAAAAMCGZhcmRlbHMAAAABdXEAfgACAAAACgZmbGVzaAAAAAF1cQB+AAIAAAAIBGZseQAAAAF1cQB+AAIAAAAIBGZvcgAAAAJ1cQB+AAIAAAAMCGZvcnR1bmUAAAABdXEAfgACAAAACQVmcm9tAAAAAXVxAH4AAgAAAAkFZ2l2ZQAAAAF1cQB+AAIAAAAKBmdyZWF0AAAAAXVxAH4AAgAAAAoGZ3J1bnQAAAABdXEAfgACAAAACQVoYXZlAAAAAnVxAH4AAgAAAAcDaGUAAAABdXEAfgACAAAADgpoZWFydGFjaGUAAAABdXEAfgACAAAACQVoZWlyAAAAAXVxAH4AAgAAAAwIaGltc2VsZgAAAAF1cQB+AAIAAAAIBGhpcwAAAAF1cQB+AAIAAAAIBGh1ZQAAAAF1cQB+AAIAAAAJBWlsbHMAAAABdXEAfgACAAAABwNpbgAAAAN1cQB+AAIAAAAOCmluc29sZW5jZQAAAAF1cQB+AAIAAAAHA2lzAAAAA3VxAH4AAgAAAAkFa25vdwAAAAF1cQB+AAIAAAAIBGxhdwAAAAF1cQB+AAIAAAAJBWxpZmUAAAACdXEAfgACAAAACQVsb25nAAAAAXVxAH4AAgAAAAkFbG9zZQAAAAF1cQB+AAIAAAAJBWxvdmUAAAABdXEAfgACAAAACQVtYWtlAAAAAnVxAH4AAgAAAAoGbWFrZXMAAAACdXEAfgACAAAACARtYW4AAAABdXEAfgACAAAACARtYXkAAAABdXEAfgACAAAACgZtZXJpdAAAAAF1cQB+AAIAAAAKBm1pZ2h0AAAAAXVxAH4AAgAAAAkFbWluZAAAAAF1cQB+AAIAAAALB21vbWVudAAAAAF1cQB+AAIAAAAJBW1vcmUAAAABdXEAfgACAAAACwdtb3J0YWwAAAABdXEAfgACAAAACQVtdXN0AAAAAXVxAH4AAgAAAAcDbXkAAAABdXEAfgACAAAACQVuYW1lAAAAAXVxAH4AAgAAAAsHbmF0aXZlAAAAAXVxAH4AAgAAAAwIbmF0dXJhbAAAAAF1cQB+AAIAAAAHA25vAAAAAnVxAH4AAgAAAAsHbm9ibGVyAAAAAXVxAH4AAgAAAAgEbm90AAAAAnVxAH4AAgAAAAgEbm93AAAAAXVxAH4AAgAAAAoGbnltcGgAAAABdXEAfgACAAAABgJvAAAAAXVxAH4AAgAAAAcDb2YAAAAPdXEAfgACAAAACARvZmYAAAABdXEAfgACAAAACwdvZmZpY2UAAAABdXEAfgACAAAADAhvcGhlbGlhAAAAAXVxAH4AAgAAAA0Jb3Bwb3NpbmcAAAABdXEAfgACAAAADgpvcHByZXNzb3IAAAABdXEAfgACAAAABwNvcgAAAAJ1cQB+AAIAAAAMCG9yaXNvbnMAAAABdXEAfgACAAAACwdvdGhlcnMAAAABdXEAfgACAAAADwtvdXRyYWdlb3VzAAAAAXVxAH4AAgAAAAkFcGFsZQAAAAF1cQB+AAIAAAAKBnBhbmdzAAAAAXVxAH4AAgAAAAwIcGF0aWVudAAAAAF1cQB+AAIAAAAKBnBhdXNlAAAAAXVxAH4AAgAAAA4KcGVyY2hhbmNlAAAAAXVxAH4AAgAAAAkFcGl0aAAAAAF1cQB+AAIAAAAKBnByb3VkAAAAAXVxAH4AAgAAAAwIcHV6emxlcwAAAAF1cQB+AAIAAAANCXF1ZXN0aW9uAAAAAXVxAH4AAgAAAAwIcXVpZXR1cwAAAAF1cQB+AAIAAAALB3JhdGhlcgAAAAF1cQB+AAIAAAALB3JlZ2FyZAAAAAF1cQB+AAIAAAANCXJlbWVtYmVyAAAAAXVxAH4AAgAAAA8LcmVzb2x1dGlvbgAAAAF1cQB+AAIAAAAMCHJlc3BlY3QAAAABdXEAfgACAAAADAhyZXR1cm5zAAAAAXVxAH4AAgAAAAgEcnViAAAAAXVxAH4AAgAAAAYCcwAAAAV1cQB+AAIAAAAIBHNheQAAAAF1cQB+AAIAAAALB3Njb3JucwAAAAF1cQB+AAIAAAAIBHNlYQAAAAF1cQB+AAIAAAALB3Nob2NrcwAAAAF1cQB+AAIAAAANCXNodWZmbGVkAAAAAXVxAH4AAgAAAA0Jc2lja2xpZWQAAAABdXEAfgACAAAACQVzaW5zAAAAAXVxAH4AAgAAAAoGc2xlZXAAAAAFdXEAfgACAAAACwdzbGluZ3MAAAABdXEAfgACAAAABwNzbwAAAAF1cQB+AAIAAAAJBXNvZnQAAAABdXEAfgACAAAADgpzb21ldGhpbmcAAAABdXEAfgACAAAACwdzcHVybnMAAAABdXEAfgACAAAACwdzdWZmZXIAAAABdXEAfgACAAAACgZzd2VhdAAAAAF1cQB+AAIAAAAJBXRha2UAAAABdXEAfgACAAAACgZ0YWtlcwAAAAF1cQB+AAIAAAAJBXRoYW4AAAABdXEAfgACAAAACQV0aGF0AAAAB3VxAH4AAgAAAAgEdGhlAAAAFnVxAH4AAgAAAAoGdGhlaXIAAAABdXEAfgACAAAACQV0aGVtAAAAAXVxAH4AAgAAAAoGdGhlcmUAAAACdXEAfgACAAAACgZ0aGVzZQAAAAF1cQB+AAIAAAAJBXRoaXMAAAACdXEAfgACAAAACgZ0aG9zZQAAAAF1cQB+AAIAAAAMCHRob3VnaHQAAAABdXEAfgACAAAADQl0aG91c2FuZAAAAAF1cQB+AAIAAAAJBXRodXMAAAACdXEAfgACAAAACAR0aHkAAAABdXEAfgACAAAACQV0aW1lAAAAAXVxAH4AAgAAAAgEdGlzAAAAAnVxAH4AAgAAAAcDdG8AAAAPdXEAfgACAAAADgp0cmF2ZWxsZXIAAAABdXEAfgACAAAADQl0cm91YmxlcwAAAAF1cQB+AAIAAAAJBXR1cm4AAAABdXEAfgACAAAACgZ1bmRlcgAAAAF1cQB+AAIAAAAPC3VuZGlzY292ZXIAAAABdXEAfgACAAAADQl1bndvcnRoeQAAAAF1cQB+AAIAAAAHA3VzAAAAA3VxAH4AAgAAAAcDd2UAAAAEdXEAfgACAAAACgZ3ZWFyeQAAAAF1cQB+AAIAAAAJBXdoYXQAAAABdXEAfgACAAAACQV3aGVuAAAAAnVxAH4AAgAAAAwId2hldGhlcgAAAAF1cQB+AAIAAAAKBndoaXBzAAAAAXVxAH4AAgAAAAgEd2hvAAAAAnVxAH4AAgAAAAoGd2hvc2UAAAABdXEAfgACAAAACQV3aWxsAAAAAXVxAH4AAgAAAAkFd2lzaAAAAAF1cQB+AAIAAAAJBXdpdGgAAAADdXEAfgACAAAACgZ3b3VsZAAAAAJ1cQB+AAIAAAAKBndyb25nAAAAAXVxAH4AAgAAAAgEeW91AAAAAXg="
}
}
}
```
> Cache JobExecutionResult from finished JobManagerRunners
> --------------------------------------------------------
>
> Key: FLINK-8234
> URL: https://issues.apache.org/jira/browse/FLINK-8234
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Gary Yao
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to serve the {{JobExecutionResults}} we have to cache them in the
> {{Dispatcher}} after the {{JobManagerRunner}} has finished. The cache should
> have a configurable size and should periodically clean up stale entries in
> order to avoid memory leaks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
