[
https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287919#comment-16287919
]
ASF GitHub Bot commented on FLINK-8178:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5105#discussion_r156426879
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
---
@@ -155,13 +159,13 @@ public Void call() throws Exception {
recordWriter.clearBuffers();
// Verify that buffer have been requested, but only one
has been written out.
- verify(bufferProvider,
times(2)).requestBufferBlocking();
+ verify(bufferProvider,
times(2)).requestBufferBuilderBlocking();
verify(partitionWriter,
times(1)).writeBuffer(any(Buffer.class), anyInt());
// Verify that the written out buffer has only been
recycled once
// (by the partition writer).
- assertTrue("Buffer not recycled.", buffer.isRecycled());
- verify(buffer, times(1)).recycle();
+ assertEquals(1,
recycler.getRecycledMemorySegments().size());
+ assertEquals(memorySegment,
recycler.getRecycledMemorySegments().get(0));
--- End diff --
Of course if we used `TestPooledBufferProvider`, then we could only check
the number of recycled memory segments here but isn't that enough since we do
not use the recycler anywhere else?
> Introduce not threadsafe write only BufferBuilder
> -------------------------------------------------
>
> Key: FLINK-8178
> URL: https://issues.apache.org/jira/browse/FLINK-8178
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Fix For: 1.5.0
>
>
> While Buffer class is used in multithreaded context it requires
> synchronisation. Now it is miss-leading/unclear and suggesting that
> RecordSerializer should take into account synchronisation of the Buffer
> that's holding. With NotThreadSafe BufferBuilder there would be clear
> separation between single-threaded writing/creating a BufferBuilder and
> multithreaded Buffer handling/retaining/recycling.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
