[ 
https://issues.apache.org/jira/browse/FLINK-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285749#comment-16285749
 ] 

ASF GitHub Bot commented on FLINK-8235:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5146

    [FLINK-8235][build] Spotbugs exclusion file path now absolute

    ## What is the purpose of the change
    
    With this PR the spotbugs plugin can now be run on a single sub-module. The 
path to the exclusion file is now absolute and no longer relies on in which 
module it is executed.
    
    ## Verifying this change
    
    Run {{mvn package -Dspotbugs}} in any sub-module.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8235

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5146
    
----
commit d50a8f78279001c50cbeb05f9e91edc21a25202c
Author: zentol <ches...@apache.org>
Date:   2017-12-11T10:44:57Z

    [FLINK-8235][build] Spotbugs exclusion file path now absolute

----


> Cannot run spotbugs for single module
> -------------------------------------
>
>                 Key: FLINK-8235
>                 URL: https://issues.apache.org/jira/browse/FLINK-8235
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.5.0, 1.4.1
>
>
> When running the spotbugs plugin ({{-Dspotbugs}}) in a sub-module of Flink 
> the build will fail because it cannot find the exclusion file.
> {code}
> [ERROR] Could not find resource 'tools/maven/spotbugs-exclude.xml'. -> [Help 
> 1]
> {code}
> The problem is that the configured relative path is resolved against the 
> sub-module directory, and not the parent one.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to