Github user casidiablo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5134#discussion_r155667757
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/benchmark/SerializingLongReceiver.java
 ---
    @@ -0,0 +1,101 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.io.network.benchmark;
    +
    +import org.apache.flink.runtime.io.network.api.reader.MutableRecordReader;
    +import org.apache.flink.runtime.io.network.partition.consumer.InputGate;
    +import org.apache.flink.runtime.util.EnvironmentInformation;
    +import org.apache.flink.types.LongValue;
    +
    +/**
    + * {@link ReceiverThread} that deserialize incoming messages.
    + */
    +public class SerializingLongReceiver extends ReceiverThread {
    +
    +    private long maxLatency = Long.MIN_VALUE;
    +    private long minLatency = Long.MAX_VALUE;
    +    private long sumLatency;
    +    private long sumLatencySquare;
    +    private int numSamples;
    +
    +    private final MutableRecordReader<LongValue> reader;
    +
    +    public SerializingLongReceiver(InputGate inputGate, int 
expectedRepetitionsOfExpectedRecord) {
    +        super(expectedRepetitionsOfExpectedRecord);
    +        this.reader = new MutableRecordReader<>(
    +            inputGate,
    +            new String[]{
    +                EnvironmentInformation.getTemporaryFileDirectory()
    +            });
    +    }
    +
    +    protected void readRecords(long lastExpectedRecord) throws Exception {
    --- End diff --
    
    Add `@Override`?


---

Reply via email to