[
https://issues.apache.org/jira/browse/FLINK-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280378#comment-16280378
]
ASF GitHub Bot commented on FLINK-8087:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155279729
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java ---
@@ -312,24 +312,36 @@ public void returnAllocatedSlot(Slot slot) {
// (1) do we have a slot available already?
SlotAndLocality slotFromPool = availableSlots.poll(resources,
locationPreferences);
if (slotFromPool != null) {
- SimpleSlot slot = createSimpleSlot(slotFromPool.slot(),
slotFromPool.locality());
--- End diff --
Method `createSimpleSlot` is no longer in use.
> Decouple Slot from SlotPool
> ---------------------------
>
> Key: FLINK-8087
> URL: https://issues.apache.org/jira/browse/FLINK-8087
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> In order to let the {{SlotPool}} return a a different {{LogicalSlot}}
> implementation than {{SimpleSlot}} we should not store the {{Slot}} inside of
> the {{SlotPool}}. Moreover, we should introduce a abstraction for the
> {{AllocatedSlot}} which contains the information required by the
> {{SimpleSlot}}. That way we decouple the {{SimpleSlot}} from the
> {{AllocatedSlot}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
