[GitHub] flink pull request #5115: [FLINK-7692] [metrics] Support user-defined variab...

[zentol]

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5115#discussion_r154965270
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
 ---
    @@ -441,14 +441,14 @@ private MetricGroup addGroup(String name, boolean 
keyed) {
                        }
                        else {
                                // return a non-registered group that is 
immediately closed already
    -                           GenericMetricGroup closedGroup = 
createChildGroup(name);
    +                           GenericMetricGroup closedGroup = 
createChildGroupInKeyedContext(name);
    --- End diff --
    
    Lets return a GenericMetricGroup here to keep this case as simple as 
possible.


---