Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5122#discussion_r154925706
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBAsyncSnapshotTest.java
 ---
    @@ -333,7 +339,7 @@ public void testCleanupOfSnapshotsInFailureCase() 
throws Exception {
     
                RocksDBStateBackend backend = new 
RocksDBStateBackend(stateBackend);
     
    -           backend.setDbStoragePath("file:///tmp/foobar");
    +           backend.setDbStoragePath("file://" + 
temporaryFolder.newFolder().getAbsolutePath());
    --- End diff --
    
    To make this cross compatible with Windows (and other OSs), can you change 
that to 
`backend.setDbStoragePath(temporaryFolder.newFolder().toUri().toString());`


---

Reply via email to