Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-115652087
All in all this looks good.
The only think that strikes me is the of the test pattern(that way used
also before by the tests. I am not a big fan of validating results in an
`@After` method. I find the tests more readable if they simply call the
comparison themselves at the end:
```java
List<Tuple2<String, Integer>> result = data.collect()
String expected = "Hello,2\n" +
"Dude,5\n"
compareResultAsTuples(expexted, result)
```
This also solves the issue with the raw type lists, which is usually an
indicator that something is not modeled in the right way (unless you
dynamically load or instantiate types).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
