Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5048#discussion_r154499363
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/TaskManagerGateway.java
 ---
    @@ -186,4 +187,12 @@ void triggerCheckpoint(
         * @return Future blob key under which the task manager stdout file has 
been stored
         */
        CompletableFuture<TransientBlobKey> requestTaskManagerStdout(final Time 
timeout);
    +
    +   /**
    +    * Notify the slot is unused.
    +    *
    +    * @param allocationID allocation id of the slot
    +    * @return Future acknowledge if notify successfully
    +    */
    +   CompletableFuture<Acknowledge> notifySlotUnused(AllocationID 
allocationID);
    --- End diff --
    
    The `TaskExecutor` contains the method `freeSlot(AllocationID allocationId, 
Throwable cause)`. Maybe we should simply expose this method as a RPC call. 
Then we don't have to implement a new method which simply calls `freeSlot`.


---

Reply via email to