Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154121821
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -43,8 +46,8 @@
private static volatile MetricRegistryConfiguration
defaultConfiguration;
- // regex pattern to split the defined reporters
- private static final Pattern splitPattern =
Pattern.compile("\\s*,\\s*");
+ // regex pattern to extract the name from reporter configuration keys,
e.g. "rep" from "metrics.reporter.rep.class"
+ private static final Pattern configurationPattern =
Pattern.compile("metrics\\.reporter\\.([\\S&&[^.]]*)\\..*");
--- End diff --
Can we `Pattern.quote(ConfigConstants.METRICS_REPORTER_PREFIX)`?
---
