[ 
https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270829#comment-16270829
 ] 

ASF GitHub Bot commented on FLINK-7880:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5062#discussion_r153790466
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/AbstractServerTest.java
 ---
    @@ -86,77 +83,89 @@ public void testServerInitializationFailure() throws 
Throwable {
         */
        @Test
        public void testPortRangeSuccess() throws Throwable {
    -           TestServer server1 = null;
    -           TestServer server2 = null;
    -           Client<TestMessage, TestMessage> client = null;
     
    -           try {
    -                   server1 = startServer("Test Server 1", 7777, 7778, 
7779);
    +           // this is shared between the two servers.
    +           AtomicKvStateRequestStats serverStats = new 
AtomicKvStateRequestStats();
    +           AtomicKvStateRequestStats clientStats = new 
AtomicKvStateRequestStats();
    +
    +           List<Integer> portList = new ArrayList<>();
    +           portList.add(7777);
    +           portList.add(7778);
    +           portList.add(7779);
    +
    +           try (
    +                           TestServer server1 = new TestServer("Test 
Server 1", serverStats, portList.iterator());
    +                           TestServer server2 = new TestServer("Test 
Server 2", serverStats, portList.iterator());
    +                           TestClient client = new TestClient(
    +                                           "Test Client",
    +                                           1,
    +                                           new MessageSerializer<>(new 
TestMessage.TestMessageDeserializer(), new 
TestMessage.TestMessageDeserializer()),
    +                                           clientStats
    +                           )
    +           ) {
    +                   server1.start();
                        Assert.assertEquals(7777L, 
server1.getServerAddress().getPort());
    --- End diff --
    
    these should be removed, or generalized to `portRangeStart <= 
server1.getServerAddress().getPort() <= portRangeEnd`. 


> flink-queryable-state-java fails with core-dump
> -----------------------------------------------
>
>                 Key: FLINK-7880
>                 URL: https://issues.apache.org/jira/browse/FLINK-7880
>             Project: Flink
>          Issue Type: Bug
>          Components: Queryable State, Tests
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Kostas Kloudas
>            Priority: Critical
>              Labels: test-stability
>
> The {{flink-queryable-state-java}} module fails on Travis with a core dump.
> https://travis-ci.org/tillrohrmann/flink/jobs/289949829



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to