[
https://issues.apache.org/jira/browse/FLINK-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270550#comment-16270550
]
ASF GitHub Bot commented on FLINK-8007:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5098
[FLINK-8007][metrics] Move TestMeter/-Histogram into metrics-core test
scope
## What is the purpose of the change
This PR moves the `TestMeter` and `TestingHistogram` to the test sources of
`flink-metrics-core`.
The `TestMeter` class was previously part of the main sources of
`flink-metrics-core` by accident, while `TestingHistogram` was in the test
sources of `flink-runtime`.
The goal consolidate things a bit, and to reduce the dependency on
flink-runtime for testing reporters.
Additionally, this PR contains a small cleanup of some reporter poms to
remove unused declared / used undeclared dependencies.
## Brief change log
* move TestMeter into test scope of flink-metrics-core
* move TestingHistogram to to flink-metrics-core as
* rename TestingHistogram to TestHistogram
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8007
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5098.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5098
----
commit cf75e516f720c5d4da8cdf1088c93fd637b2dc97
Author: zentol <ches...@apache.org>
Date: 2017-11-28T21:07:36Z
[FLINK-8007][metrics] Move TestMeter into test scope
commit 695e3431ec1395db76b5364e3da2c34fc2fddf04
Author: zentol <ches...@apache.org>
Date: 2017-11-28T21:09:17Z
[hotfix][metrics] Cleanup reporter poms
----
> Move TestMeter class to test scope
> ----------------------------------
>
> Key: FLINK-8007
> URL: https://issues.apache.org/jira/browse/FLINK-8007
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Trivial
> Fix For: 1.5.0
>
>
> The TestMeter class in flink-metrics-core is only for test purposes, but is
> not located in the test src directory.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
