Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5070#discussion_r153448795
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
 ---
    @@ -188,13 +188,6 @@ object ScalarOperators {
             (leftTerm, rightTerm) => s"java.util.Arrays.equals($leftTerm, 
$rightTerm)"
           }
         }
    -    // map types
    -    else if (isMap(left.resultType) &&
    -      left.resultType.getTypeClass == right.resultType.getTypeClass) {
    -      generateOperatorIfNotNull(nullCheck, BOOLEAN_TYPE_INFO, left, right) 
{
    -        (leftTerm, rightTerm) => s"java.util.Map.equals($leftTerm, 
$rightTerm)"
    --- End diff --
    
    Do we really need to remove the entire functionality? Wouldn't be 
`$leftTerm.equals($rightTerm)` be enough?


---

Reply via email to