[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267109#comment-16267109
]
ASF GitHub Bot commented on FLINK-7416:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153258008
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -88,6 +98,15 @@ void cancelRequestFor(InputChannelID inputChannelId) {
}
}
+ void notifyCreditAvailable(final RemoteInputChannel inputChannel) {
--- End diff --
Can you please add a comment under which circumstances not to call this,
i.e. we must make sure, `ctx` is assigned yet (so after the channel has been
activated somehow). I checked the uses of this method and those seem to be
safe, i.e. in `RemoteInputChannel`s `#notifyBufferAvailable()`,
`#onSenderBacklog()`, and `#recycle()`. All of these should only happen after
some interaction with the channel.
> Implement Netty receiver outgoing pipeline for credit-based
> -----------------------------------------------------------
>
> Key: FLINK-7416
> URL: https://issues.apache.org/jira/browse/FLINK-7416
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> The related works are :
> * We define a new message called {{AddCredit}} to notify the incremental
> credit during data shuffle.
> * Whenever an {{InputChannel}}’s unannounced credit goes up from zero, the
> channel is enqueued in the pipeline.
> * Whenever the channel becomes writable, it takes the next {{InputChannel}}
> and sends its unannounced credit. The credit is reset to zero after each sent.
> * That way, messages are sent as often as the network has capacity and
> contain as much credit as available for the channel at that point in time.
> Otherwise, it would only add latency to the announcements and not increase
> throughput.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
