[
https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266819#comment-16266819
]
ASF GitHub Bot commented on FLINK-7694:
---------------------------------------
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5084
[FLINK-7694][flip6] Migrate JobMetricsHandler to new RestServerEndpoint
## What is the purpose of the change
*FLIP-6 efforts: Migrating HTTP handlers*
## Brief change log
- Migrate logic from
`org.apache.flink.runtime.rest.handler.legacy.metrics.JobMetricsHandler to` new
handler.
- Add new handler to `DispatcherRestEndpoint`.
## Verifying this change
- *Added unit tests for all new classes and modified existing classes
except for DispatcherRestEndpoint.*
- *Manually deployed a job locally and verified with `curl` that Job
metrics can be queried in FLIP-6 standalone mode.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
CC: @tillrohrmann
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink FLINK-7694
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5084.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5084
----
commit 7a3bdc5a8c2c53a9b4219d1fab7faf5490d1ef92
Author: gyao <g...@data-artisans.com>
Date: 2017-11-27T13:34:03Z
[FLINK-7694][flip6] Migrate JobMetricsHandler to new RestServerEndpoint
Migrate logic in
org.apache.flink.runtime.rest.handler.legacy.metrics.JobMetrisHandler to new
handler, and add new handler to DispatcherRestEndpoint.
----
> Port JobMetricsHandler to new REST handler
> ------------------------------------------
>
> Key: FLINK-7694
> URL: https://issues.apache.org/jira/browse/FLINK-7694
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, REST, Webfrontend
> Reporter: Bowen Li
> Assignee: Gary Yao
> Labels: flip6
> Fix For: 1.5.0
>
>
> Port
> {{org.apache.flink.runtime.rest.handler.legacy.metrics.JobMetricsHandler}} to
> new handler that works with {{RestServerEndpoint}}. Add new handler to
> {{DispatcherRestEndpoint}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
