[
https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266442#comment-16266442
]
ASF GitHub Bot commented on FLINK-7574:
---------------------------------------
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5076
[FLINK-7574][build] POM Cleanup flink-clients
Re-created #4712.
## What is the purpose of the change
This PR changes the `flink-clients` pom to
- contain unused dependencies
- contain all used dependencies
## Brief change log
- *Define the `maven-dependency-plugin` plugin version in root POM
pluginManagement*
- *Enable `dependency:analyze-only` at root POM plugins*
- *Disable the dependency analysis of flink submodules, except the
`flink-clients`*
- *Cleanup`flink-clients` dependencies(used but undeclared / declared but
unused)*
- *[travis] Only execute `dependency:analyze-only` in "Misc" profile*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink FLINK-7574
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5076
----
commit ea12f28d16591041c42222b087dd54a32f40797a
Author: yew1eb <yew...@gmail.com>
Date: 2017-11-22T15:03:26Z
[FLINK-7574][build] POM Cleanup flink-clients
----
> flink-clients
> -------------
>
> Key: FLINK-7574
> URL: https://issues.apache.org/jira/browse/FLINK-7574
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Affects Versions: 1.3.2
> Environment: Apache Maven 3.3.9, Java version: 1.8.0_144
> Reporter: Hai Zhou UTC+8
> Assignee: Hai Zhou UTC+8
>
> [INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @
> flink-clients_2.11 ---
> [WARNING] Used undeclared dependencies found:
> [WARNING] org.scala-lang:scala-library:jar:2.11.11:compile
> [WARNING] com.data-artisans:flakka-actor_2.11:jar:2.3-custom:compile
> [WARNING] Unused declared dependencies found:
> [WARNING] org.hamcrest:hamcrest-all:jar:1.3:test
> [WARNING] org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
> [WARNING] org.powermock:powermock-module-junit4:jar:1.6.5:test
> [WARNING] com.google.code.findbugs:jsr305:jar:1.3.9:compile
> [WARNING] log4j:log4j:jar:1.2.17:test
> [WARNING] org.powermock:powermock-api-mockito:jar:1.6.5:test
> [WARNING] org.slf4j:slf4j-log4j12:jar:1.7.7:test
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
