Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4581#discussion_r152837725
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
 ---
    @@ -300,6 +315,230 @@ public void 
testConsumeSpillablePartitionSpilledDuringConsume() throws Exception
                assertTrue(buffer.isRecycled());
        }
     
    +   /**
    --- End diff --
    
    could some of those tests be squashed into fewer methods? Or you think that 
wouldn't be a good idea?


---

Reply via email to