[
https://issues.apache.org/jira/browse/FLINK-4500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249046#comment-16249046
]
ASF GitHub Bot commented on FLINK-4500:
---------------------------------------
GitHub user mcfongtw opened a pull request:
https://github.com/apache/flink/pull/5002
[hotfix][docs] Remove the caveat about Cassandra connector.
## What is the purpose of the change
Remove a caveat in Cassandra connector docs.
## Brief change log
As FLINK-4500 being committed, Cassandra connector would now flush pending
mutations properly when a checkpoint was triggered. Thus, remove the related
caveat from documents.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcfongtw/flink hotfix-doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5002.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5002
----
commit e6d13baa2544c1ac0504199f685b12872451d0e1
Author: Michael Fong <mcfong.o...@gmail.com>
Date: 2017-11-13T02:17:02Z
[hotfix][docs] Remove the caveat about Cassandra connector.
As FLINK-4500 being committed, Cassandra connector would now flush pending
mutations properly when a checkpoint was triggered.
----
> Cassandra sink can lose messages
> --------------------------------
>
> Key: FLINK-4500
> URL: https://issues.apache.org/jira/browse/FLINK-4500
> Project: Flink
> Issue Type: Bug
> Components: Cassandra Connector
> Affects Versions: 1.1.0
> Reporter: Elias Levy
> Assignee: Michael Fong
> Fix For: 1.4.0
>
>
> The problem is the same as I pointed out with the Kafka producer sink
> (FLINK-4027). The CassandraTupleSink's send() and CassandraPojoSink's send()
> both send data asynchronously to Cassandra and record whether an error occurs
> via a future callback. But CassandraSinkBase does not implement
> Checkpointed, so it can't stop checkpoint from happening even though the are
> Cassandra queries in flight from the checkpoint that may fail. If they do
> fail, they would subsequently not be replayed when the job recovered, and
> would thus be lost.
> In addition,
> CassandraSinkBase's close should check whether there is a pending exception
> and throw it, rather than silently close. It should also wait for any
> pending async queries to complete and check their status before closing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
