Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4993#discussion_r150226027
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
 ---
    @@ -166,27 +168,39 @@ public String getClientName() {
         *
         * <p>After a call to this method, all returned futures will be failed.
         */
    -   public void shutdown() {
    +   public CompletableFuture<Boolean> shutdown() {
    +           final CompletableFuture<Boolean> shutdownFuture = new 
CompletableFuture<>();
    +
                if (shutDown.compareAndSet(false, true)) {
    +                   final List<CompletableFuture<?>> connectionFutures = 
new ArrayList<>();
    --- End diff --
    
    could be initialized with the number of established + pending connections.


---

Reply via email to