Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4729#discussion_r149636445
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -227,14 +242,27 @@ public void startNewWorker(ResourceProfile 
resourceProfile) {
        }
     
        @Override
    -   public boolean stopWorker(ResourceID resourceID) {
    -           // TODO: Implement to stop the worker
    -           return false;
    +   public boolean stopWorker(YarnWorkerNode workerNode) {
    +           if (workerNode != null) {
    +                   Container container = workerNode.getContainer();
    +                   log.info("Stopping container {}.", 
container.getId().toString());
    --- End diff --
    
    `toString` call unnecessary.


---

Reply via email to