[
https://issues.apache.org/jira/browse/FLINK-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241913#comment-16241913
]
ASF GitHub Bot commented on FLINK-8006:
---------------------------------------
GitHub user elbaulp opened a pull request:
https://github.com/apache/flink/pull/4968
[FLINK-8006] [Startup Shell Scripts] Enclosing $pid in quotes
## What is the purpose of the change
When executing `./bin/start-local.sh` The following errors appears:
flink-1.3.2/bin/flink-daemon.sh: line 79: $pid: ambiguous redirect
This is because $pid contains spaces, so to fix it I've enclose I replaced
all $pid by "$pid"
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no /
don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
No
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elbaulp/flink fix-FLINK-8006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4968.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4968
----
commit 5eb46d363e3eaab321759e18f55b9a96270e523f
Author: Alejandro Alcalde <algu...@gmail.com>
Date: 2017-11-07T12:09:46Z
[FLINK-8006] Enclosing in quotes
----
> flink-daemon.sh: line 103: binary operator expected
> ---------------------------------------------------
>
> Key: FLINK-8006
> URL: https://issues.apache.org/jira/browse/FLINK-8006
> Project: Flink
> Issue Type: Bug
> Components: Startup Shell Scripts
> Affects Versions: 1.3.2
> Environment: Linux 4.12.12-gentoo #2 SMP x86_64 Intel(R) Core(TM)
> i3-3110M CPU @ 2.40GHz GenuineIntel GNU/Linux
> Reporter: Alejandro
> Labels: easyfix, newbie
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> When executing `./bin/start-local.sh` I get
> flink-1.3.2/bin/flink-daemon.sh: line 79: $pid: ambiguous redirect
> flink-1.3.2/bin/flink-daemon.sh: line 103: [: /tmp/flink-Alejandro: binary
> operator expected
> I solved the problem replacing $pid by "$pid" in lines 79 and 103.
> Should I make a PR to the repo?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
