[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237748#comment-16237748 ]
ASF GitHub Bot commented on FLINK-7076: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r148809690 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -260,6 +287,7 @@ public void onContainersAllocated(List<Container> containers) { numPendingContainerRequests = Math.max(0, numPendingContainerRequests - 1); log.info("Received new container: {} - Remaining pending container requests: {}", container.getId(), numPendingContainerRequests); + workerNodeMap.put(container.getId().toString(), new YarnWorkerNode(container)); --- End diff -- Here we should create a `ResourceID` to use it as the key. This `ResourceID` must then be send to the launched TaskManager such that it uses it upon registration. > Implement container release to support dynamic scaling > ------------------------------------------------------ > > Key: FLINK-7076 > URL: https://issues.apache.org/jira/browse/FLINK-7076 > Project: Flink > Issue Type: Sub-task > Components: ResourceManager > Reporter: Till Rohrmann > Assignee: Shuyi Chen > Priority: Major > Labels: flip-6 > > In order to support dynamic scaling, the {{YarnResourceManager}} has to be > able to dynamically free containers. We have to implement the > {{YarnResourceManager#stopWorker}} method. -- This message was sent by Atlassian JIRA (v6.4.14#64029)