[
https://issues.apache.org/jira/browse/FLINK-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234396#comment-16234396
]
ASF GitHub Bot commented on FLINK-7800:
---------------------------------------
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4934
[FLINK-7800] [table] Enable window joins without equi-join predicates
## What is the purpose of the change
This PR enables the stream window joins without equi-join predicates.
## Brief change log
- Push down all the predicate checks from `FlinkLogicalRule` to
DataSet/DataStream rules so that we can organise them in a flat mode.
- Create a `JoinPlanUtil` tool to provide utilities (e.g., equi-predicate
checker) for join plan translation.
- Give priority to join plans with equi-join predicates by subtracting 1
from the IO cost.
- Add related tests.
- Update the documents.
## Verifying this change
This change can be verified by the added tests in `JoinTest` and
`JoinITCase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (**no**)
- The serializers: (**no**)
- The runtime per-record code paths (performance sensitive): (**yes**)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (docs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xccui/flink FLINK-7800
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4934.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4934
----
commit 2ec1571475214e16eae54e69d4b5beb88a8b6fdc
Author: Xingcan Cui <xingc...@gmail.com>
Date: 2017-10-27T03:11:21Z
[FLINK-7800] [table] Enable window joins without equi-join predicates
----
> Enable window joins without equi-join predicates
> ------------------------------------------------
>
> Key: FLINK-7800
> URL: https://issues.apache.org/jira/browse/FLINK-7800
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Fabian Hueske
> Assignee: Xingcan Cui
> Priority: Major
>
> Currently, windowed joins can only be translated if they have at least on
> equi-join predicate. This limitation exists due to the lack of a good cross
> join strategy for the DataSet API.
> Due to the window, windowed joins do not have to be executed as cross joins.
> Hence, the equi-join limitation does not need to be enforces (even though
> non-equi joins are executed with a parallelism of 1 right now).
> We can resolve this issue by adding a boolean flag to the
> {{FlinkLogicalJoinConverter}} rule to permit non-equi joins and add such a
> rule to the logical optimization set of the DataStream API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
