[ 
https://issues.apache.org/jira/browse/FLINK-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227260#comment-16227260
 ] 

ASF GitHub Bot commented on FLINK-7922:
---------------------------------------

Github user walterddr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4929#discussion_r148083555
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/SetOperatorsTest.scala
 ---
    @@ -178,4 +182,54 @@ class SetOperatorsTest extends TableTestBase {
           expected
         )
       }
    +
    +  @Test
    +  def testUnionNullableTypes(): Unit = {
    --- End diff --
    
    I think this should also be added to stream API as well but I am not sure 
which test category it falls into.


> leastRestrictive in FlinkTypeFactory does not resolve composite type correctly
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-7922
>                 URL: https://issues.apache.org/jira/browse/FLINK-7922
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>
> FlinkTypeFactory does not override the following function correctly:
> {code:java}
> def leastRestrictive(types: util.List[RelDataType]): RelDataType = {
>   //... 
> }
> {code}
> dealing with SQL such as:
> {code:sql}
> CASE 
>   WHEN <CONDITION> THEN 
>     <COMPOSITE_TYPE> 
>   ELSE 
>     NULL 
> END
> {code}
> will trigger runtime exception. 
> See following test sample for more details:
> https://github.com/walterddr/flink/commit/a5f2affc9bbbd50f06200f099c90597e519e9170



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to