GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/4928

    [FLINK-7732][kafka-consumer] Do not commit to kafka Flink's sentinel offsets

    ## What is the purpose of the change
    
    This pull request fixes a bug in all versions of `KafkaConsumer`s, that 
resulted in application crash, if snapshot before `KafkaConsumer` was able to 
asynchronously properly initialize.
    
    ## Verifying this change
    
    This change adds additional unit test in `AbstractFetcherTest` and a check 
state to ensure/enforce contract that internal sentinel offsets will not be 
committed to Kafka. 
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink f7732

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4928.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4928
    
----
commit 9baea16ca69c27e5153808ce01592a47091c3131
Author: Piotr Nowojski <piotr.nowoj...@gmail.com>
Date:   2017-10-31T14:38:32Z

    [FLINK-7732][kafka-consumer] Do not commit to kafka Flink's sentinel offsets

----


---

Reply via email to