[
https://issues.apache.org/jira/browse/FLINK-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221977#comment-16221977
]
ASF GitHub Bot commented on FLINK-7933:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4908#discussion_r147357330
--- Diff:
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java
---
@@ -70,9 +69,25 @@
@Rule
public ExpectedException thrown = ExpectedException.none();
- private final MetricRegistry registry = new
MetricRegistry(MetricRegistryConfiguration.fromConfiguration(createConfigWithOneReporter("test1",
"" + NON_DEFAULT_PORT)));
- private final FrontMetricGroup<TaskManagerMetricGroup> metricGroup =
new FrontMetricGroup<>(0, new TaskManagerMetricGroup(registry, HOST_NAME,
TASK_MANAGER));
- private final MetricReporter reporter = registry.getReporters().get(0);
+ private MetricRegistry registry;
+ private FrontMetricGroup<TaskManagerMetricGroup> metricGroup;
+ private PrometheusReporter reporter;
+ private int port;
--- End diff --
do we need this extra field for that? Can't we access `reporter.getPort()`?
Isn't it redundant?
> Test instability PrometheusReporterTest
> ---------------------------------------
>
> Key: FLINK-7933
> URL: https://issues.apache.org/jira/browse/FLINK-7933
> Project: Flink
> Issue Type: Bug
> Components: Metrics, Tests
> Affects Versions: 1.4.0
> Reporter: Kostas Kloudas
> Assignee: Chesnay Schepler
> Priority: Critical
> Labels: test-stability
>
> Travis log: https://travis-ci.org/kl0u/flink/jobs/293220196
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
