Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4827#discussion_r147165565
  
    --- Diff: flink-test-utils-parent/flink-test-utils/pom.xml ---
    @@ -117,6 +124,41 @@ under the License.
                                <inherited>true</inherited>
                                <extensions>true</extensions>
                        </plugin>
    +
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-shade-plugin</artifactId>
    +                           <executions>
    +                                   <execution>
    +                                           <id>shade-flink</id>
    +                                           <phase>package</phase>
    +                                           <goals>
    +                                                   <goal>shade</goal>
    +                                           </goals>
    +                                           <configuration>
    +                                                   <artifactSet>
    +                                                           <includes 
combine.children="append">
    +                                                                   
<include>io.netty:netty</include>
    +                                                           </includes>
    +                                                   </artifactSet>
    +                                                   <relocations 
combine.children="append">
    +                                                           <relocation>
    +                                                                   
<pattern>org.jboss.netty</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.shaded.testutils.org.jboss.netty</shadedPattern>
    --- End diff --
    
    Good question, maybe @pnowojski can answer that... My guess is he was more 
familiar with the Netty 3 API (org.jboss.netty) and our shaded netty is Netty 4 
(io.netty).


---

Reply via email to