[ 
https://issues.apache.org/jira/browse/FLINK-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220520#comment-16220520
 ] 

ASF GitHub Bot commented on FLINK-7051:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4873#discussion_r147120015
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
 ---
    @@ -849,17 +848,7 @@ object AggregateUtil {
           outputType
         )
     
    -    val constantFlags: Option[Array[(Int, Boolean)]] =
    -    if (inGroupingSet) {
    -
    -      val groupingSetsMapping = getGroupingSetsIndicatorMapping(inputType, 
outputType)
    --- End diff --
    
    `getGroupingSetsIndicatorMapping()` method can be removed as well 
everything related to the `constantFlags` parameter in 
`AggregationCodeGenerator`, `GeneratedAggregations`, 
`DawtaSetFinalAggFunction`, etc.


> Bump up Calcite version to 1.14
> -------------------------------
>
>                 Key: FLINK-7051
>                 URL: https://issues.apache.org/jira/browse/FLINK-7051
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Haohui Mai
>            Priority: Critical
>             Fix For: 1.4.0
>
>
> This is an umbrella issue for all tasks that need to be done once Apache 
> Calcite 1.14 is released.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to