[
https://issues.apache.org/jira/browse/FLINK-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218509#comment-16218509
]
ASF GitHub Bot commented on FLINK-7846:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4902
[FLINK-7846] [elasticsearch] Remove unnecessary guava shading
2nd attempt of #4834, which i accidentally closed while merging another
commit.
## What is the purpose of the change
This PR removes the guava shading from the ES2 connector. The shading is
pointless since the only possible guava user is the elasticsearch dependency,
which is not included in the jar, and thus unaffected by the shading.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7846
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4902.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4902
----
commit 82436bfd11c586f639917f4f38422cbeb5dbe408
Author: zentol <ches...@apache.org>
Date: 2017-10-16T11:49:55Z
[FLINK-7846] [elasticsearch] Remove unnecessary guava shading
----
> Remove guava shading from ES2 connector
> ---------------------------------------
>
> Key: FLINK-7846
> URL: https://issues.apache.org/jira/browse/FLINK-7846
> Project: Flink
> Issue Type: Bug
> Components: Build System, ElasticSearch Connector
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: 1.4.0
>
>
> The ElasticSearch 2 connector pom has a shading configuration for guava. The
> only user of guava is the elasticsearch dependency, which is not included in
> the jar, making the shading pointless.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
