[
https://issues.apache.org/jira/browse/FLINK-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211186#comment-16211186
]
ASF GitHub Bot commented on FLINK-5968:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4833#discussion_r145726822
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/MapView.scala
---
@@ -52,7 +52,7 @@ import
org.apache.flink.table.dataview.MapViewTypeInfoFactory
* return accum;
* }
*
- * public void accumulate(MyAccum accumulator, String id) {
+ * public MyAccum accumulate(MyAccum accumulator, String id) {
--- End diff --
Please revert these changes.
The `accumulate` method belongs to a Table API
`org.apache.flink.table.functions.AggregateFunction` and not
`GeneratedAggregations`.
> Document WindowedStream.aggregate()
> -----------------------------------
>
> Key: FLINK-5968
> URL: https://issues.apache.org/jira/browse/FLINK-5968
> Project: Flink
> Issue Type: Sub-task
> Components: DataStream API, Documentation
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Blocker
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
