[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209188#comment-16209188 ]
Kurt Young commented on FLINK-7548: ----------------------------------- Hi [~fhueske], sorry for the late response. I'm not very familiar with streaming related stuffs, but I like the idea to separate the schema and actual returned type, it makes the concepts more clear. One question here, do you think table schema should be remain immutable once we defined it. Like a CsvTableSource, IMO the schema should be fixed once we decide which file to read. But according to your WIP branch, if project pushed down into CsvTableSource, it also changes the table schema. I'm not sure this is correct. What do you think? > Support watermark generation for TableSource > -------------------------------------------- > > Key: FLINK-7548 > URL: https://issues.apache.org/jira/browse/FLINK-7548 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: Jark Wu > Assignee: Fabian Hueske > Priority: Blocker > Fix For: 1.4.0 > > > As discussed in FLINK-7446, currently the TableSource only support to define > rowtime field, but not support to extract watermarks from the rowtime field. > We can provide a new interface called {{DefinedWatermark}}, which has two > methods {{getRowtimeAttribute}} (can only be an existing field) and > {{getWatermarkGenerator}}. The {{DefinedRowtimeAttribute}} will be marked > deprecated. > How to support periodic and punctuated watermarks and support some built-in > strategies needs further discussion. -- This message was sent by Atlassian JIRA (v6.4.14#64029)