Github user suez1224 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4729#discussion_r145325673
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile
resourceProfile) {
}
@Override
- public void stopWorker(ResourceID resourceID) {
- // TODO: Implement to stop the worker
+ public void stopWorker(YarnWorkerNode workerNode) {
+ workerNodeMap.remove(workerNode.getResourceID().toString());
--- End diff --
Since we will need to keep workerNodeMap anyway, we can actually just look
up the containerId using resourceId from workerNodeMap, there is no need to
calculate the containerId from resourceId, so I think we dont need to use
ContainerId.fromString. Also, copying the code will have compatibility issue if
the fromString method differ in different hadoop version. What do you think?
---
