Github user zhijiangW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r144181936
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandler.java
 ---
    @@ -330,6 +330,10 @@ else if (bufferProvider.isDestroyed()) {
                }
        }
     
    +   void notifyCreditAvailable(RemoteInputChannel inputChannel) {
    +           // Implement in CreditBasedClientHandler
    --- End diff --
    
    The `PartitionRequestClientHandler` will keep the current network logic, 
and all the credit-based logics are implemented in new 
`CreditBasedClientHandler`. 
    Finally the `PartitionRequestClientHandler` will be replaced by 
`CreditBasedClientHandler`.


---

Reply via email to