[
https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200022#comment-16200022
]
ASF GitHub Bot commented on FLINK-7076:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4729#discussion_r143958924
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile
resourceProfile) {
}
@Override
- public void stopWorker(ResourceID resourceID) {
- // TODO: Implement to stop the worker
+ public void stopWorker(YarnWorkerNode workerNode) {
+ workerNodeMap.remove(workerNode.getResourceID().toString());
+ if (workerNode != null) {
+ log.info("Stopping container {}.",
workerNode.getYarnContainer().getId().toString());
+
resourceManagerClient.releaseAssignedContainer(workerNode.getYarnContainer().getId());
--- End diff --
I think we should also call `nodeManagerClient.stopContainer()` before.
> Implement container release to support dynamic scaling
> ------------------------------------------------------
>
> Key: FLINK-7076
> URL: https://issues.apache.org/jira/browse/FLINK-7076
> Project: Flink
> Issue Type: Sub-task
> Components: ResourceManager
> Reporter: Till Rohrmann
> Assignee: Shuyi Chen
> Labels: flip-6
>
> In order to support dynamic scaling, the {{YarnResourceManager}} has to be
> able to dynamically free containers. We have to implement the
> {{YarnResourceManager#stopWorker}} method.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
