[
https://issues.apache.org/jira/browse/FLINK-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199524#comment-16199524
]
ASF GitHub Bot commented on FLINK-6697:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/4796
[FLINK-6697] [table] Add support for window.rowtime to batch Table API.
## What is the purpose of the change
This PR adds support for the `windowAlias.rowtime` property to the batch
Table API. The `rowtime` expression is already supported by the streaming Table
API.
This PR improves the unification of batch and streaming Table API queries.
## Brief change log
- adjust the validation and return type of the `RowtimeAttribute` expression
- pass rowtime index to DataSet window operators
- adjust `TimeWindowPropertyCollector` to set rowtime attribute in batch
windows
- extend existing tests to check the new window property
## Verifying this change
- existing tests in `GroupWindowITCase` were extended to check the
`rowtime` window property.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
## Documentation
- Does this pull request introduce a new feature? **yes**
- If yes, how is the feature documented? **Documentation is extended**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink tableBatchRowtime
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4796.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4796
----
commit 06fddde1ee6ad3aea17b7c11495090964cb0ef1c
Author: Fabian Hueske <fhue...@apache.org>
Date: 2017-08-06T21:55:56Z
[FLINK-6697] [table] Add support for window.rowtime to batch Table API.
----
> Add batch multi-window support
> ------------------------------
>
> Key: FLINK-6697
> URL: https://issues.apache.org/jira/browse/FLINK-6697
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: Timo Walther
> Assignee: Fabian Hueske
>
> Multiple consecutive windows on batch are not tested yet and I think they are
> also not supported, because the syntax is not defined for batch yet.
> The following should be supported:
> {code}
> val t = table
> .window(Tumble over 2.millis on 'rowtime as 'w)
> .groupBy('w)
> .select('w.rowtime as 'rowtime, 'int.count as 'int)
> .window(Tumble over 4.millis on 'rowtime as 'w2)
> .groupBy('w2)
> .select('w2.rowtime, 'w2.end, 'int.count)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
