[ 
https://issues.apache.org/jira/browse/FLINK-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198632#comment-16198632
 ] 

ASF GitHub Bot commented on FLINK-7652:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4734#discussion_r143718052
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java 
---
    @@ -242,6 +248,86 @@ public void start() throws Exception {
        }
     
        @Override
    +   public CompletableFuture<JobStatusesWithIdsOverview> 
requestJobIdsOverview(@RpcTimeout Time timeout) {
    --- End diff --
    
    I think it would be better to define `requestJobsOverview` which simply 
returns a `Collection<JobOverview>` with `JobOverview` containing the `JobID` 
and the `JobStatus`, for example. All other data processing and data 
restructuring like grouping the individual jobs to make it easier for the Web 
UI to display the content, should then happen on the handler and not in the 
`Dispatcher`. My gut feeling is that this is unnecessary coupling of unrelated 
components.


> Port CurrentJobIdsHandler to new REST endpoint
> ----------------------------------------------
>
>                 Key: FLINK-7652
>                 URL: https://issues.apache.org/jira/browse/FLINK-7652
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>              Labels: flip-6
>             Fix For: 1.4.0
>
>
> Port existing {{CurrentJobIdsHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to