Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4729#discussion_r143666272
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile 
resourceProfile) {
        }
     
        @Override
    -   public void stopWorker(ResourceID resourceID) {
    -           // TODO: Implement to stop the worker
    +   public void stopWorker(YarnWorkerNode workerNode) {
    +           workerNodeMap.remove(workerNode.getResourceID().toString());
    --- End diff --
    
    If we store the container id in `YarnWorkerNode`, then we don't need the 
`workerNodeMap`.


---

Reply via email to