[
https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196308#comment-16196308
]
Chesnay Schepler edited comment on FLINK-7608 at 10/8/17 7:52 PM:
------------------------------------------------------------------
Hold on, isn't this issue only about refactoring the latency gauge to fit the
histogram metric type? AFAIK, we already calculate everything we need for that,
so I'd rather just port it over and revisit _how_ it is implemented separately.
We seem to be mixing concerns here, with the first being about basic usability
and the latter about improving performance. I'd much rather put the focus on
making the metric usable.
was (Author: zentol):
Hold on, isn't this issue only about refactoring the latency gauge to fit the
histogram metric type? AFAIK, we already calculate everything we need for that,
so I'd rather just port it over and revisit _how_ it is implemented separately.
We seem to be mixing concerns here, with the first being about basic usability
and the latter about improving performance.
> LatencyGauge change to histogram metric
> ----------------------------------------
>
> Key: FLINK-7608
> URL: https://issues.apache.org/jira/browse/FLINK-7608
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Reporter: Hai Zhou UTC+8
> Assignee: Hai Zhou UTC+8
> Priority: Blocker
> Fix For: 1.4.0, 1.3.3
>
>
> I used slf4jReporter[https://issues.apache.org/jira/browse/FLINK-4831] to
> export metrics the log file.
> I found:
> {noformat}
> -- Gauges
> ---------------------------------------------------------------------
> ......
> zhouhai-mbp.taskmanager.f3fd3a269c8c3da4e8319c8f6a201a57.Flink Streaming
> Job.Map.0.latency:
> value={LatencySourceDescriptor{vertexID=1, subtaskIndex=-1}={p99=116.0,
> p50=59.5, min=11.0, max=116.0, p95=116.0, mean=61.833333333333336}}
> zhouhai-mbp.taskmanager.f3fd3a269c8c3da4e8319c8f6a201a57.Flink Streaming
> Job.Sink- Unnamed.0.latency:
> value={LatencySourceDescriptor{vertexID=1, subtaskIndex=0}={p99=195.0,
> p50=163.5, min=115.0, max=195.0, p95=195.0, mean=161.0}}
> ......
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
