[
https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192841#comment-16192841
]
ASF GitHub Bot commented on FLINK-7072:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r142930472
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationMessageParameters.java
---
@@ -28,8 +28,8 @@
*/
public class JobTerminationMessageParameters extends MessageParameters {
- private final JobIDPathParameter jobPathParameter = new
JobIDPathParameter();
- private final TerminationModeQueryParameter
terminationModeQueryParameter = new TerminationModeQueryParameter();
+ public final JobIDPathParameter jobPathParameter = new
JobIDPathParameter();
+ public final TerminationModeQueryParameter
terminationModeQueryParameter = new TerminationModeQueryParameter();
--- End diff --
well they aren't really internal fields, at least i didn't intend them to
be. The client has to resolve the parameters somehow, so we either have to add
a custom resolve method to every `MessageParameters` class (which will make for
an odd API when creating sub-classes), or provide access to each parameter
(either directly or through a getter). I opted for the direct approach since it
makes it obvious that we are in fact modifying the `MessageParameters` object.
> Create RESTful cluster endpoint
> -------------------------------
>
> Key: FLINK-7072
> URL: https://issues.apache.org/jira/browse/FLINK-7072
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Till Rohrmann
> Assignee: Chesnay Schepler
> Labels: flip-6
> Fix For: 1.4.0
>
>
> In order to communicate with the cluster from the RESTful client, we have to
> implement a RESTful cluster endpoint. The endpoint shall support the
> following operations:
> * List jobs (GET): Get list of all running jobs on the cluster
> * Submit job (POST): Submit a job to the cluster (only supported in session
> mode)
> * Get job status (GET): Get the status of an executed job (and maybe the
> JobExecutionResult)
> * Lookup job leader (GET): Gets the JM leader for the given job
> This endpoint will run in session mode alongside the dispatcher/session
> runner and forward calls to this component which maintains a view on all
> currently executed jobs.
> In the per-job mode, the endpoint will return only the single running job and
> the address of the JobManager alongside which it is running. Furthermore, it
> won't accept job submissions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
