[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4742#discussion_r142907629
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationMessageParameters.java
 ---
    @@ -28,8 +28,8 @@
      */
     public class JobTerminationMessageParameters extends MessageParameters {
     
    -   private final JobIDPathParameter jobPathParameter = new 
JobIDPathParameter();
    -   private final TerminationModeQueryParameter 
terminationModeQueryParameter = new TerminationModeQueryParameter();
    +   public final JobIDPathParameter jobPathParameter = new 
JobIDPathParameter();
    +   public final TerminationModeQueryParameter 
terminationModeQueryParameter = new TerminationModeQueryParameter();
    --- End diff --
    
    Hmm what about giving these values to the `JobTerminationMessageParameters` 
constructor? It feels not entirely right that we access internal fields to 
resolve them?


---