[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191086#comment-16191086 ]
Fabian Hueske commented on FLINK-7730: -------------------------------------- Thanks for looking into this [~xccui]! This looks like a Calcite problem to me. The join predicate would need to be included in the {{LogicalCorrelate}} (like in {{LogicalJoin}} but {{LogicalCorrelate}} does not have a field for a predicate (however it supports outer joins). As you said, pushing a join predicate in a subsequent filter works fine for inner joins but not for outer joins. So, I would consider this to be a bug in Calcite. Since you identified the problem, do you want to discuss the problem with the Calcite community? > TableFunction LEFT OUTER joins with ON predicates are broken > ------------------------------------------------------------ > > Key: FLINK-7730 > URL: https://issues.apache.org/jira/browse/FLINK-7730 > Project: Flink > Issue Type: Bug > Components: Table API & SQL > Affects Versions: 1.4.0, 1.3.2 > Reporter: Fabian Hueske > Assignee: Xingcan Cui > > TableFunction left outer joins with predicates in the ON clause are broken. > Apparently, the are no tests for this and it has never worked. I observed > issues on several layers: > - Table Function does not correctly validate equality predicate: > {{leftOuterJoin(func1('c) as 'd, 'a.cast(Types.STRING) === 'd)}} is rejected > because the predicate is not considered as an equality predicate (the cast > needs to be pushed down). > - Plans cannot be correctly translated: {{leftOuterJoin(func1('c) as 'd, 'c > === 'd)}} gives an optimizer exception. > - SQL queries get translated but produce incorrect results. For example > {{SELECT a, b, c, d FROM MyTable LEFT OUTER JOIN LATERAL TABLE(tfunc(c)) AS > T(d) ON d = c}} returns an empty result if the condition {{d = c}} never > returns true. However, the outer side should be preserved and padded with > nulls. > So there seem to be many issues with table function outer joins. Especially, > the wrong result produced by SQL queries need to be quickly fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)