Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4736#discussion_r142256742
  
    --- Diff: 
flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java
 ---
    @@ -86,6 +86,13 @@ public Long getValue(WeightedAvgAccum accumulator) {
                }
     
                // overloaded accumulate method
    +           // dummy to test constants
    +           public void accumulate(WeightedAvgAccum accumulator, long 
iValue, int iWeight, int x, String string) {
    +                   accumulator.sum += iWeight + Integer.parseInt(string);
    --- End diff --
    
    change the method to 
    ```
    accumulator.sum += (iValue + Integer.parseInt(string)) * iWeight;
    accumulator.count += iWeight;
    ``` 
    
    to have some influence of the value of `string` in the result?


---

Reply via email to